D22069: Localize long number strings

[Albert Astals Cid]

aacid added a comment.


  In D22069#523253 <https://phabricator.kde.org/D22069#523253>, @ngraham wrote:
  
  > I'm not sure I understand about about localization to figure that out. Would you be able to help me out?
  
  
  Figure *what* out?
  
  Just remove this
  
    diff --git a/autotests/klocalizedstringtest.cpp b/autotests/klocalizedstringtest.cpp
    index e1863c4..d8ac31b 100644
    --- a/autotests/klocalizedstringtest.cpp
    +++ b/autotests/klocalizedstringtest.cpp
    @@ -219,13 +219,8 @@ void KLocalizedStringTest::correctSubs()
         QCOMPARE(ki18n("%1").subs(42, -5, 10, QChar('_')).toString(),
                  QString("42___"));
     
    -    QLocale::setDefault(QLocale(QLocale::French));
         QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),
                  QString(" 4,20"));
    -
    -    QLocale::setDefault(QLocale(QLocale::English, QLocale::UnitedStates));
    -    QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),
    -             QString(" 4.20"));
  
  And that's it?
  
  If what you're saying is that that you run ./bin/ki18n-klocalizedstringtest without those lines and the test fails for you, well you'll have to give me access to your machine since i can't fix what i can't debug (i.e. it works fine here)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190901/9a026423/attachment.html>