D25067: Fix the header layouts for EntryDetails and Page components

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Wed Oct 30 16:32:02 GMT 2019


leinir added inline comments.

INLINE COMMENTS

> ahiemstra wrote in EntryDetails.qml:95
> It does not. I am also unsure whether `anchors.fill` will work, since the titleDelegate is instantiated by a loader and its sizing behaviour is somewhat fuzzy. The only option that is guaranteed to work is setting a proper implicitWidth for the delegate. I actually spent some time trying to get balanced auto sizing behaviour working for titles when doing the ActionToolBar work, but in the end gave up because things get really tricky when you have two items that resize based on the size of the other item.

That is terribly annoying... So, with a bit of knowledge about this specific pair of pages, i've switched this to using implicitWidths set to the width of the page itself, so... let's see if that works a bit better. (which, incidentally, it does here, at least... but so did the previous approach...)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25067

To: leinir, ngraham, #knewstuff, #frameworks, #plasma
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/412e67eb/attachment.html>


More information about the Kde-frameworks-devel mailing list