D25079: [CopyJob] Increase the amount of data sendfile can copy at once

[Méven Car]

meven added a comment.


  In D25079#556824 <https://phabricator.kde.org/D25079#556824>, @ahmadsamir wrote:
  
  > Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276
  
  
  The bug scope is rather large.
  But this will help and I suspect https://phabricator.kde.org/D23523 will too.

INLINE COMMENTS

> apol wrote in file_unix.cpp:55
> Where did you get this number from? it could be useful for when we reevaluate life.

man sendfile
http://man7.org/linux/man-pages/man2/sendfile.2.html

Found while reviewing code investigating https://bugs.kde.org/show_bug.cgi?id=342056.

> apol wrote in file_unix.cpp:272
> Why keep the if it's going to always be true?

It is used when sendfile call fails to stop using it in next iteration.

line 272 - 276  and later

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25079

To: meven, dfaure, #frameworks, davidedmundson
Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/a69e98bb/attachment.html>