D25079: [CopyJob] Increase the amount of data sendfile can copy at once

[Aleix Pol Gonzalez]

apol added a comment.


  This is really interesting, I can expect this to make the whole thing much faster.

INLINE COMMENTS

> file_unix.cpp:55
> +// On Linux, write() (and similar system calls) will transfer at most
> +// 0x7ffff000 (2,147,479,552) bytes, returning the number of bytes
> +// actually transferred.  (This is true on both 32-bit and 64-bit

Where did you get this number from? it could be useful for when we reevaluate life.

> file_unix.cpp:272
>  #ifdef USE_SENDFILE
>          if (use_sendfile) {
>              off_t sf = processed_size;

Why keep the if it's going to always be true?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25079

To: meven, dfaure, #frameworks, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/9d4605a8/attachment.html>