D25070: Make KCModuleQml conform to the defaulted() signal

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kcmoduleqml.cpp:80-82
>      if (d->configModule->needsSave()) {
>          emit changed(true);
>      }

needsSave emits the current state and then connects for changes
representsDefaults  only connects for changes

I would expect them to match as they're doing equivalent things.

It looks to me that it's this line that's somewhat pointless - we're in a constructor so only super classes could possibly have connected and we can see it doesn't.
Can you confirm.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25070

To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/7c681216/attachment.html>