D25058: Add KAboutPluginDialog, to be used with KPluginMetaData
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Oct 29 19:59:47 GMT 2019
kossebau created this revision.
kossebau added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
When showing an About dialog for a plugin, so far a
KAboutApplicationDialog had to be used, by generating an KAboutData object
from the KPluginMetaData object.
Using KAboutApplicationDialog has those disadvantages:
- the icon shown in the title widget is the one of the application, not the plugin
- the "Libraries" tab does not make much sense with a plugin, as it is the same as the shell application
- the name KAboutApplicationDialog is a mismatch when used with a plugin
TEST PLAN
About application dialog works as before in applications, the new about
plugin dialog works with KDevelop's Loaded Plugins dialog as well as
KPluginSelector.
REPOSITORY
R263 KXmlGui
BRANCH
addaboutplugindialog
REVISION DETAIL
https://phabricator.kde.org/D25058
AFFECTED FILES
src/CMakeLists.txt
src/kaboutapplicationdialog.cpp
src/kaboutapplicationdialog.h
src/kaboutplugindialog.cpp
src/kaboutplugindialog.h
src/kabstractaboutdialog_p.cpp
src/kabstractaboutdialog_p.h
src/klicensedialog_p.cpp
src/klicensedialog_p.h
To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191029/f0bbf024/attachment.html>
More information about the Kde-frameworks-devel
mailing list