D25010: [StatJob] Use A QFlag to specify the details returned by statJob
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Oct 29 13:00:38 GMT 2019
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in statjob.h:181
> I wonder if this should not be rather a member of StatJob, instead of being on generic KIO namespace level.
> It feels unbalanced to have the enum being in the class, but a util flag set not.
Actually, this could be part of the StatJob::StatDetail enum, no? Having combinations of lfags in the enum itself (to be used as shortcuts) is usual practice and also should not conflict with Q_DECLARE_FLAGS, IIRC (would need to check).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25010
To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191029/3346206c/attachment.html>
More information about the Kde-frameworks-devel
mailing list