D25039: Fix Clazy performance issues, const &, noexcept

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Fix a lot of missing const & or &, avoiding copying mostly QString.
  - Add noexept to KFileItem and UDSEntre Move and copy constructors.
  - Make an implicit conversion explicit

TEST PLAN
  ctest

REPOSITORY
  R241 KIO

BRANCH
  clazy-perf

REVISION DETAIL
  https://phabricator.kde.org/D25039

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/kcoredirlister.cpp
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/knewfilemenu.cpp
  src/gui/faviconrequestjob.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/help/kio_help.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.h
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/kpac/script.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/krun.cpp
  src/widgets/sslui.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191029/d7fe21b5/attachment.html>