D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  In D24928#553952 <https://phabricator.kde.org/D24928#553952>, @vkrause wrote:
  
  > The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being consumed? If this is purely used for display, maybe let's just replace the entire string in there by QSslCipher::name()?
  
  
  Looking at how ktorrent uses KIO::MetaData: https://lxr.kde.org/source/extragear/network/libktorrent/src/tracker/httptracker.cpp#0480
  
  gave me an idea to search for "ssl_cipher" on lxr.k.o, I found no hits at all. So nothing uses it in KDE, I don't know about 3rd party users. So maybe we just remove the digest method (or the whole sslCipher string), especially since cipher.name() is pretty descriptive.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191026/5186e5fa/attachment.html>