D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Oct 26 18:02:28 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> kaboutdata.h:944
>  
> -#if KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2)
> +#if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2)
>      /**

Possibly best to document why only BUILD, pointing out infrastructure code supporting legacy code needs to always see this, unless disabled from build explicitly.
To avoid the next person thinking this was a mistake and changing to ENABLE again.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191026/c1ed7002/attachment.html>


More information about the Kde-frameworks-devel mailing list