D24932: [WIP]: Add Button to open the folder in filelight for more details

[Nathaniel Graham]

ngraham added a comment.


  Much better, thanks.

INLINE COMMENTS

> kpropertiesdialog.cpp:1097
> +        
> +        if (QStandardPaths::findExecutable(QStringLiteral("filelight")) != QString()) {
> +            d->m_sizeDetailsButton = new QPushButton(i18n("Explore in Filelight?"), d->m_frame);

`isEmpty()` is preferred over comparing to `QString()`

> kpropertiesdialog.cpp:1100
> +            d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(QStringLiteral("filelight")));
> +            connect(d->m_sizeDetailsButton, &QAbstractButton::clicked, this, &KFilePropsPlugin::slotSizeDetails);
> +        }

This is a `QPushButton`, so connect to `&QPushButton::clicked`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191026/333de617/attachment.html>