D24938: Fix memory leak in KXzFilter::init

Albert Astals Cid noreply at phabricator.kde.org
Thu Oct 24 23:54:22 BST 2019


aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  I wasn't 99% sure we need to free the filters so early since we're passing them to the functions that manipulate the streams,
  but having a look at various other code using lzma they also free them very early and the fact that everything still works is also a good indicator

TEST PLAN
  Before valgrind --leak-check=full karchivetest gave memory leaks, now it does not

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24938

AFFECTED FILES
  src/kxzfilter.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191024/893d5ac0/attachment.html>


More information about the Kde-frameworks-devel mailing list