D24908: fix default shortcut detection

Harald Sitter noreply at phabricator.kde.org
Thu Oct 24 23:21:52 BST 2019


sitter added inline comments.

INLINE COMMENTS

> aacid wrote in kshortcuteditwidget.cpp:72
> this is wrong, isn't it?
> 
> Or at least behaviour changing, before m_defaultLabel was set to None, when defaultText was empty. Now it's not?

it's initialized to None via the ctor at line 68 already. now that I notice it, defaultText could also be const now.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191024/add006a9/attachment.html>


More information about the Kde-frameworks-devel mailing list