D24895: [RFC] Drop implicit size from PC buttons

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It makes buttons in apps using plasma as a QQC2 style weirdly wide.
  
  A comment suggests that this is intentional for compatibility reasons. @mart can you please expand on why this was necessary and whether it still is?
  
  A workaround for applications for this issue would be to set an explicit implicit size (heh), but doing that /everywhere/ souds wrong to me

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  mo

REVISION DETAIL
  https://phabricator.kde.org/D24895

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191023/4bacf34f/attachment.html>