D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)It will break code as:struct MessageStatusInfo { const char *text; const char *icon; }; static const MessageStatusInfo...

Laurent Montel noreply at phabricator.kde.org
Wed Oct 23 12:19:51 BST 2019


mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  ...StatusValues[] = {
  
    { I18N_NOOP2("message status", "Important"), "emblem-important"    },
  
  ...
  }
  
  it will return 3 elements and not 2.
  
  I think that idea was to remove this macro as name was not good.
  So I added a new macro which strip context
  
  Allow to replace I18N_NOOP2 macro

TEST PLAN
  make test

REPOSITORY
  R249 KI18n

BRANCH
  de_deprecated_i18n_noop2

REVISION DETAIL
  https://phabricator.kde.org/D24884

AFFECTED FILES
  src/klocalizedstring.h

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191023/f8cebfb4/attachment.html>


More information about the Kde-frameworks-devel mailing list