D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Friedrich W. H. Kossebau]

kossebau added a comment.


  As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also wrap the implementation of assignIconsToContextMenu, with #if KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_).
  
  Seems you are a candidate to answer the email https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/095831.html, please :)

INLINE COMMENTS

> kicontheme.h:291
>       */
> -    static void assignIconsToContextMenu(ContextMenus type, QList<QAction *> actions);
> +    KICONTHEMES_DEPRECATED_VERSION(5, 64, "No longer necessary") static void assignIconsToContextMenu(ContextMenus type, QList<QAction *> actions); // TODO KF6 remove
> +#endif

IMHO moving the KICONTHEMES_DEPRECATED_VERSION onto an own line improves readability, especially with longer "what to do now" text arguments.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24764

To: vkrause, mlaurent
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191022/eba1439a/attachment-0001.html>