D24821: Add ManagedConfigModule
David Edmundson
noreply at phabricator.kde.org
Mon Oct 21 10:54:15 BST 2019
davidedmundson added a comment.
Nice!
I'm not super sold on magically doing findChildren to get the config skeletons over an explicit
registerSettings(KCoreConfigSkeleton*).
I'm not against it either, but could you expand on the rationale.
INLINE COMMENTS
> managedconfigmodule.cpp:131
> + needsSave |= skeleton->isSaveNeeded();
> + if (needsSave)
> + break;
Coding style {} is needed for single lines
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D24821
To: ervin, #plasma, #frameworks, mart, bport
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191021/325c0bc0/attachment.html>
More information about the Kde-frameworks-devel
mailing list