D24821: Add ManagedConfigModule

Benjamin Port noreply at phabricator.kde.org
Mon Oct 21 10:34:38 BST 2019


bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> managedconfigmodule.cpp:96
> +{
> +    return false;
> +}

Like above I think we need to set it to true

> managedconfigmodule.h:210
> +     *
> +     * By default this returns false, it needs to be overriden only
> +     * if the module has state outside of the settings declared in

I think we need to set this value to true by default, because if we don't override it we assume value are not the default one

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191021/c73d5da3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list