D24350: [src/kpac/*] replace deprecated foreach with range for

Ahmad Samir noreply at phabricator.kde.org
Mon Oct 21 04:42:52 BST 2019


ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in script.cpp:157
> Why not just change this one to return `const &` and then use it in all range-fors?
> 
> [note that returning a const ref is bad in public API, but this is an internal method so we can always change it again if needed]

Because I didn't pay attention to public v.s. private API :)

Fixing.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191021/a57a9126/attachment.html>


More information about the Kde-frameworks-devel mailing list