D24350: [src/kpac/*] replace deprecated foreach with range for

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  sorry, missed this one. thanks for the ping.

INLINE COMMENTS

> script.cpp:157
>  
>      QList<QHostAddress> addresses() const
>      {

Why not just change this one to return `const &` and then use it in all range-fors?

[note that returning a const ref is bad in public API, but this is an internal method so we can always change it again if needed]

> script.cpp:162
>  
> +    const QList<QHostAddress> &addressesList() const
> +    {

it's just weird to have two methods that do the same thing, with a different name.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191020/e0f33297/attachment.html>