D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kstatusnotifieritem.cpp:454
>      Qt::WindowFlags oldFlags = d->menu->windowFlags();
>      d->menu->setParent(nullptr);
>      d->menu->setWindowFlags(oldFlags);

Do not take ownership of the menu and delete it when it does not have a parent. takeOwnership is wrong approach, you can remove it.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191019/26a08863/attachment.html>