D23927: Improve naming of KTitleWidget icon methods

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Oct 16 23:27:10 BST 2019


kossebau added a comment.


  In D23927#548607 <https://phabricator.kde.org/D23927#548607>, @kossebau wrote:
  
  > Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated" one.
  
  
  Hmpf, I mixed up signatures and added "#if KWIDGETSADDONS_BUILD_DEPRECATED_SINCE(5, 63)" to the wrong method, all fine there, sorry for that noise.
  
  Still, complain about the API consistency still holds, please consider fixing it :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191016/c19b3f52/attachment.html>


More information about the Kde-frameworks-devel mailing list