D24663: Use ECMGenerateExportHeader to manage deprecated API better

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Oct 16 09:33:43 BST 2019


zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:741
>  
> -#ifndef KWAYLANDSERVER_NO_DEPRECATED
>  void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop)

Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.

Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191016/2287bf89/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list