D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree
    Ahmad Samir 
    noreply at phabricator.kde.org
       
    Tue Oct 15 20:25:29 BST 2019
    
    
  
ahmadsamir added a comment.
  In D24672#547744 <https://phabricator.kde.org/D24672#547744>, @mkoller wrote:
  
  > why ?
  >  I don't like lots of these changes.
  
  
  Because it doesn't follow the KDE coding style, AFAICS (and changing it to use that common style will make it easier for whoever is going to work on porting it away from kdelibs4support[1]).
  
  Anyway, if you disagree, I'll drop this review request. :)
  
  [1]https://phabricator.kde.org/T11576
REPOSITORY
  R374 KolourPaint
REVISION DETAIL
  https://phabricator.kde.org/D24672
To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: ognarb, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191015/168f8593/attachment.html>
    
    
More information about the Kde-frameworks-devel
mailing list