D24667: Activate when both associatedWidget and menu are null

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> kstatusnotifieritem.cpp:619
>  
> -    if (d->associatedWidget == d->menu) {
> +    if (d->associatedWidget && d->associatedWidget == d->menu) {
>          d->statusNotifierItemDBus->ContextMenu(pos.x(), pos.y());

This should fix a situation when both are NULL

> kstatusnotifieritemdbus_p.cpp:293
>  {
> -    if (m_statusNotifierItem->d->associatedWidget == m_statusNotifierItem->d->menu) {
> -        ContextMenu(x, y);

This check is duplicated, it should be safe to remove it here.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191015/4c0998e7/attachment.html>