D24667: Activate when both associatedWidget and menu are null

Konrad Materka noreply at phabricator.kde.org
Tue Oct 15 15:34:12 BST 2019


kmaterka created this revision.
kmaterka added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  If associatedWidget and menu are the same then instead of "activate"
  action context menu is used. When both are null coparition is always
  true but context menu can't be shown, since it is null.
  It is partial solution for a problem described in BUG 365105.

TEST PLAN
  As described in the bug:
  
  - create QSystemTrayIcon
  - assign QMenu
  - show, hide and show again
  
  Both right click and left click do nothing.
  
  After change left click works

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24667

AFFECTED FILES
  src/kstatusnotifieritem.cpp
  src/kstatusnotifieritemdbus_p.cpp

To: kmaterka, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191015/3f72e5b2/attachment.html>


More information about the Kde-frameworks-devel mailing list