D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  In D24588#546229 <https://phabricator.kde.org/D24588#546229>, @dfaure wrote:
  
  > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  
  
  My reasoning is, konversation only needs to know about SslUi::askIgnoreSslErrors and not  KSslErrorUiData (implementation detail in SslUi). It's more "streamlined" for users of askIgnoreSslErrors to pass it an SSL socket rather than a KSslErrorUiData object. Anyway, I don't mind either way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191012/cea20212/attachment.html>