D23579: port ftp slave to new error reporting system

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Excellent work!

INLINE COMMENTS

> ftp.cpp:2635
> +
> +#pragma message "was this useful? I have no clue where or how keepalive would work with ftp"
> +        //        authenticator->setOption(QStringLiteral("keepalive"), info.keepPassword);

yeah, looks like wishful thinking.... remove?

> sitter wrote in ftp.h:70
> It's a good idea. Would that work though?
> 
> Currently the results rely on the implicit move operator when collecting the returned result
> 
>   result = ftpGet()
> 
> if the members are const we couldn't move/copy like that anymore.
> 
> If we consider the mutability a problem I think I'd just make the members private and give them getters. I don't mind much either way.

Copying bool+int+QString seems rather cheap, we lived with that until C++11 move semantics ;-)

Private members and inline getters sounds good to me.

But yeah, no big deal, we can also trust the programmer :-)

REPOSITORY
  R241 KIO

BRANCH
  ftp

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191012/d8e57375/attachment.html>