D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krun.cpp:1101
> +        return ExecutableFileOpenDialog::OpenOrExecute;
> +    } else if (mime.inherits(QStringLiteral("application/x-ms-dos-executable"))) {
> +        return ExecutableFileOpenDialog::OpenAsExecute;

should this be in ifdef Q_OS_WIN?

On windows, *.exe is executed, not opened (with e.g. wine)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191011/b9b5d4ed/attachment.html>