D24560: remove legacy space handling code

Harald Sitter noreply at phabricator.kde.org
Fri Oct 11 13:59:34 BST 2019


sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the raw data in kioslaverc uses the format "$url $port", this format
  isn't being read inside the KCM anymore though. instead setProxyInformation
  is called with the output of KProtocolManager::proxyFor, which internally
  merges the config entry to "$url:$port" already, so the space handling in
  setProxyInformation was entirely superfluous and needlessly raising
  complexity

TEST PLAN
  saving and changing proxy settings continues to work

REPOSITORY
  R241 KIO

BRANCH
  remove-dead-proxy-load-code

REVISION DETAIL
  https://phabricator.kde.org/D24560

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191011/367c9cfd/attachment.html>


More information about the Kde-frameworks-devel mailing list