D24559: simplify the url parsing
Harald Sitter
noreply at phabricator.kde.org
Fri Oct 11 13:58:24 BST 2019
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
all urls need to have their ports stripped and text set, so de-duplicate
the shared code out of the conditional branches to prevent bugs from
making changes in one branch but not the other
TEST PLAN
saving and changing proxy settings continues to work
REPOSITORY
R241 KIO
BRANCH
simplify-proxy-load
REVISION DETAIL
https://phabricator.kde.org/D24559
AFFECTED FILES
src/kcms/kio/kproxydlg.cpp
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191011/b87d28cf/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list