D24558: fix proxy setting loading
Harald Sitter
noreply at phabricator.kde.org
Fri Oct 11 13:57:25 BST 2019
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
when the flag isn't set we'd set the text to urlStr, urlStr however
was the original string *with* the port. since we want the port stripped
we need to actually set url.url() otherwise the KCM loading its own
settings would result in
Proxy: [socks://localhost:1080] Port: [1080]
which when written back to the file would result in broken data as we
do not sanitize the proxy url text WRT port when saving
TEST PLAN
- set proxy
- close and open kcm again
- proxy values are what they were set to with no extra port duplication
REPOSITORY
R241 KIO
BRANCH
fix-proxy-load
REVISION DETAIL
https://phabricator.kde.org/D24558
AFFECTED FILES
src/kcms/kio/kproxydlg.cpp
To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191011/f8f9faee/attachment.html>
More information about the Kde-frameworks-devel
mailing list