D23579: WIP: port ftp slave to new error reporting system

[Harald Sitter]

sitter updated this revision to Diff 67695.
sitter marked 24 inline comments as done.
sitter added a comment.


  - rebase
  - ftpSendCmd now returns a bool (continues to require_result)
  - openConnection now emits opened()
  - listDir now finalize()s
  - debug--
  - ftpSendCmd's lazy login now checks the return value of the recrusive cmd call
  
  ftpOpenControlConnection's proxy handling is completely redone:
  
  - loosened nesting
  - socks5 is now also supported as scheme
  - reliance on eventloop is gone and replaced with actually sync behavior for the sync synchronousConnectToHost
    - the way proxy management is done is no longer using applicationproxy but instead managing the proxy on the socket(s) directly. this makes things somewhat more explicit and gives less opportunity for errors inside Qt behavior
    - now returns a composite Result type to carry both context and socket to the caller. contextual error forwarding is handy here because there is value in differntiating why authentication isn't working when e.g. kiod is defunct.
    - qauthenticator use gone as it has no api outside the auth signal
    - proxyAuthentication and saveProxyAuthentication have been merged into synchronousConnectToHost and been simplified
      - now only uses one AuthInfo object
      - realm is no longer set (came from QAuthenticator but as far as I can tell the QA created by QAbstractSocket has no realm set, so this never did anything anyway)
      - as a result the comment field in password queries is now only showing the hostname instead of a broken " at $hostname"
  - added ProxyTesting.md with some guidance on how to test this stuff

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23579?vs=66747&id=67695

BRANCH
  ftp

REVISION DETAIL
  https://phabricator.kde.org/D23579

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ftp/testCopy1
  autotests/ftp/testCopy2
  autotests/ftp/testOverwriteCopy1
  autotests/ftp/testOverwriteCopy2
  autotests/ftpd
  autotests/ftptest.cpp
  cmake/FindGem.cmake
  cmake/FindGem.cmake.in
  cmake/FindRubyExe.cmake
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/ftp/ftp.h

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191011/6bd8c214/attachment.html>