D24465: Use ECMGenerateExportHeader to manage deprecated API better

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Oct 10 22:48:38 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> zzag wrote in netwm_def.h:336-339
> This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0)`, right?

Hmm... I should have checked the patch after uploading. IIRC I initially had this guarded here, same with the OverrideMask, but then found that too much code seems to rely on this, so I reverted things and added a TODO: Seemingly not the state here, and sadly nothing found in my stash. Sorry, I will have to recheck this.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191010/a9d29e6e/attachment.html>


More information about the Kde-frameworks-devel mailing list