D24263: edit mode action

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 9 14:21:31 BST 2019


broulik added inline comments.

INLINE COMMENTS

> corona.cpp:378
> +        switch (d->immutability) {
> +        case Types::UserImmutable:
> +            action->setEnabled(false);

Why is this switch to explicitly stating all the cases?
The action is always visible and enabled only when Mutable

> corona.cpp:379
> +        case Types::UserImmutable:
> +            action->setEnabled(false);
> +            action->setVisible(true);

fall-through?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191009/a7cf7da1/attachment.html>


More information about the Kde-frameworks-devel mailing list