D24463: Treat "application/x-ms-dos-executable" as executable on all platforms
    Yi-Jyun Pan 
    noreply at phabricator.kde.org
       
    Tue Oct  8 13:38:57 BST 2019
    
    
  
ppeter added inline comments.
INLINE COMMENTS
> executablefileopendialog.cpp:58
> +
> +    if (mode == OnlyExecute) {
> +        connect(executeButton, &QPushButton::clicked, [=]{done(ExecuteFile);});
if (mode == OnlyExecute)
    connect(executeButton, ...)
  else if (mode == OpenAsExecute)
    ...
looks better :)
REPOSITORY
  R241 KIO
BRANCH
  master
REVISION DETAIL
  https://phabricator.kde.org/D24463
To: guoyunhe, #frameworks, ngraham, dfaure
Cc: ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191008/705190cb/attachment-0001.html>
    
    
More information about the Kde-frameworks-devel
mailing list