D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Aleix Pol Gonzalez]

apol added a comment.


  +1 in spirit.

INLINE COMMENTS

> test_notifiers.cpp.ref:7
> +TestNotifiers::TestNotifiers( int Number, QObject *parent )
>    : KConfigSkeleton( QStringLiteral( "test7rc" ) )
>    , mParamNumber(Number)

Maybe it would be better to use the parent argument in KConfigSkeleton?
explicit KConfigSkeleton(const QString &configname = QString(), QObject *parent = nullptr);

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191008/78fd1cb4/attachment.html>