D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation
Mason McParlane
noreply at phabricator.kde.org
Mon Oct 7 21:14:37 BST 2019
masonm created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
masonm requested review of this revision.
REVISION SUMMARY
Build fails to generate binary resource (breeze-icons.rcc) by default. The proposed patch fixes this by adding the QtCore directory to the qrcAlias command invocation.
TEST PLAN
1. In root of breeze-icons project generate the project using CMake with install prefix set
2. The resultant makefiles or .vcxproj files should have PATH=<path to qt core> (on Windows) and LD_LIBRARY_PATH=<path to qt core> (on Unix)
3. Build the install target
4. Verify that breeze-icons.rcc was successfully copied to <install prefix>/bin/data/icons/breeze
5. Same as 3 but for breeze-icons-dark.rcc
Note: it must be tested when Qt is //not// already in the PATH or LD_LIBRARY_PATH
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D24477
AFFECTED FILES
CMakeLists.txt
To: masonm
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191007/521f33b9/attachment.html>
More information about the Kde-frameworks-devel
mailing list