D24443: Add a plugin system

[David Edmundson]

davidedmundson added a comment.


  Plan makes sense.

INLINE COMMENTS

> calendarentry.h:35
> +    Q_PROPERTY(CalendarType type READ type CONSTANT)
> +    Q_PROPERTY(KCalendarCore::Calendar::Ptr calendar READ calendar CONSTANT)
> +public:

If the intention is for QML to be able to get and access the CalendarCore::Calendar object this won't work. You'll need to return the raw pointer.

> calendarentry.h:57
> +public Q_SLOTS:
> +    void sync();
> +

I don't understand what this is for.

Is it like Calendar::save ?

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma
Cc: davidedmundson, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191007/e6aa82d5/attachment.html>