D23787: [baloo_file_extractor] Improve handling of large plain-text files

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> app.cpp:173
> -        if (fileInfo.size() >= 10 * 1024 * 1024) {
> -            tr->removePhaseOne(id);
> -            return;

This original line seemed very very wrong.

Just because we won't want to index phase 2 isn't a reason to remove the filename indexing - it'll just keep running phase 1 on itself again and again.

So +1 on that

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191004/32752e76/attachment.html>