D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Dominik Haumann]

dhaumann added a comment.


  I think it's fine as is. The docbook says:
  
    Detect an exact string but additionally require word boundaries
    such as a dot <userinput>'.'</userinput> or a whitespace on the beginning
    and the end of the word. Think of <userinput>\b<string>\b</userinput>
    in terms of a regular expression, but it is faster than the rule <userinput>RegExpr</userinput>.
  
  Imo `<userinput>\b<string>\b</userinput>` implies that if a string itself starts/ends with a \b character, then this should match as well. And given our unit tests do not show any changes, I think we are good to go.
  
  Please commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-worddetect

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191003/d67a66d3/attachment.html>