D24367: Some sanity verification

Christoph Feck noreply at phabricator.kde.org
Wed Oct 2 18:16:25 BST 2019


cfeck added inline comments.

INLINE COMMENTS

> pcx.cpp:312
> +            qWarning() << "Failed to get scanline for" << y << "might be out of bounds";
> +        }
>          for (int x = 0; x < header.width(); ++x) {

If `p` indeed could be zero, the next statements need to be in an `else` block (or a add a `return`).

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D24367

To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191002/bb6c8435/attachment.html>


More information about the Kde-frameworks-devel mailing list