D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added a comment.


  In D21235#536576 <https://phabricator.kde.org/D21235#536576>, @hallas wrote:
  
  > In D21235#535951 <https://phabricator.kde.org/D21235#535951>, @bruns wrote:
  >
  > > In D21235#535861 <https://phabricator.kde.org/D21235#535861>, @hallas wrote:
  > >
  > > > I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would like to use the `KMountPoint` class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?
  > >
  > >
  > > What do you gain by using KMountPoints? Solid already has code for parsing fstab style files.
  >
  >
  > Hi @bruns , no you are right that I should be able to do with the code that is in Solid already. It just needs to be updated to be able parse an arbitrary mtab file. But anyhow, the fstab/mtab code in Solid seems kind of duplicated with the code in KIO, so we might consolidate at some point.
  >
  > But let me look into the mtab code in Solid and see if I can make it work there :)
  
  
  Ok, I have been playing around with the code and using getmntent for parsing the `~/.mtab.fuseiso` file, but the getmntent function doesn't give me the first field, which is the path to the iso (this is the information I am looking for). So currently I am looking at just reading in the file, splitting the space separated lines and extracting the two first fields. If anyone has ideas to do this in a smarter way, please let me know ;) I will post an updated review once I have some working code.

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191001/1af4fce2/attachment-0001.html>