D25583: Quit baloo_file_extractor if DB transaction fails

Méven Car noreply at phabricator.kde.org
Thu Nov 28 10:32:11 GMT 2019


meven added inline comments.

INLINE COMMENTS

> davidedmundson wrote in app.cpp:145
> There's a tonne in the transaction code

Alright but since the program exits here, I am concerned it may not be clear enough to the user/caller as to why it exited ?
Adding a log here will add a different context.
Also `QCoreApplication::exit(-1);`?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191128/d57ab1bc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list