D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently I have a broken DB, the worst part is that I'm in a 100% CPU
  loop.
  
  baloo-file runs, sees some files need phase 2 extraction, and launches
  the extractor. The extractor fails to update the DB which means they're
  never marked as complete or failed.
  
  baloo-file then keeps sending the same files
  
  By having the extractor bail, it at least stops.

TEST PLAN
  Ran baloo-file
  It fails for 20 files or so (one batch) then stops

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25583

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractor/app.cpp

To: davidedmundson
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191127/a62b4e5b/attachment.html>