D25516: Remove unrequired private declarations for taglibextractor

Alexander Stippich noreply at phabricator.kde.org
Wed Nov 27 08:12:30 GMT 2019


astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:105
> This puts `readGenericProperties(...)` with external linkage in the global namespace.
> 
> Put the private helpers in an anonymous namespace (and also include `extractAudioProperties(...)` in it).

Urgh, that was the plan actually. I could swear I've done that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191127/921e279c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list