D25311: Add KColumnHeadersProxyModel

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kcolumnheadersmodel.cpp:22
> +
> +class KColumnHeadersModel::Private
> +{

Instead of using a nested class Private, consider using a non-nested KColumnHeadersModelPrivate class.
Otherwise you want to tag this class to not inherit the symbol visibility attributes, using Q_DECL_HIDDEN. Not going nested spares to do this.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191126/2ed384d6/attachment.html>