D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:979
> This method should be const

A B C, nothing changed inside make it const, D E F.

> dfaure wrote in ftp.cpp:1232
> Should this be remoteEncoding()->decode(...) given that the method will then use q->remoteEncoding()->encode()?
> 
> (I'm a bit confused with kremoteencoding, I could be wrong)

Yes, that makes much more sense; using remoteEncoding()->decode() makes this bit of code consistent with the reset of how the ftp ioslave handles encoding.

> dfaure wrote in kcookiespolicies.cpp:367
> fromLatin1 is enough for adviceToStr, like you did on line 177 (so it's inconsistent)
> 
> (repeats 3 more times)

Apparently I was confused by the I18N_NOOP calls in adviceToStr, but looking again now, the translations aren't saved in the config file...

> dfaure wrote in smbrodlg.cpp:122
> You could remove the QChar() around I guess.

You're just being polite.

> dfaure wrote in main.cpp:199
> Ouch.
> 
>   QFileInfo info(it->path)
> 
> should be enough.

In my defence, since that looks a bit too crazy even to me, I was worried about files with names that have encoding issues, e.g. the dreaded �; but looking up just a little at the code I see that fileList was written by the code, so if the encoding did go south, that ship has sailed and already has sunk :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191124/c54dcc08/attachment.html>