D25444: Fix assistant dialog margins
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Nov 21 17:08:54 GMT 2019
kossebau added inline comments.
INLINE COMMENTS
> kassistantdialog.cpp:102
> + q->pageWidget()->layout()->setContentsMargins(
> + q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutLeftMargin),
> + q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutTopMargin),
Ideally q->pageWidget()->style() would be cached, given we are in hotpath here during startup, also helps codereading a bit.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D25444
To: ngraham, #frameworks, cfeck, mart
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191121/12b06eee/attachment.html>
More information about the Kde-frameworks-devel
mailing list