D24993: Add integrated inline spelling menu to KTextEdit
Tommy Lincoln
noreply at phabricator.kde.org
Thu Nov 21 16:44:54 GMT 2019
pajamapants3000 added a comment.
@cfeck - I was referring to `SpellingMenu::addWordToDictionary` and `SpellingMenu::ignoreWord` being inconsistent with the documentation of that (brand new) class. I don't think there should be any ABI considerations there, since it is a new class, but perhaps I am misunderstanding your comment or there are factors of which I am ignorant. I think it would be potentially useful to users of this class to be able to manually call this functionality. It isn't necessary, though, and I could just change the documentation to be consistent. But we probably don't want to merge-in this change if we might have a change of heart on the visibility of these slots later.
If there's something I'm missing (or you have any other feedback), let me know, thanks!
REPOSITORY
R310 KTextWidgets
REVISION DETAIL
https://phabricator.kde.org/D24993
To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191121/ad9d7da5/attachment.html>
More information about the Kde-frameworks-devel
mailing list